Skip to content

Reworded the Setup article about the local Symfony server #11747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2019

Conversation

javiereguiluz
Copy link
Member

On Symfony Slack, some people like @beryllium, @ro0NL and @dkarlovi mentioned that this intro article is not explicit enough about the requirement of installing the Symfony server before continuing. Let's improve it. Thanks.

@javiereguiluz javiereguiluz added this to the 4.2 milestone Jun 14, 2019
Copy link

@beryllium beryllium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes great inroads into clearing up my initial confusion & hopefully makes things easier to follow for newcomers. Thanks!

I added a couple comments that might be worth considering.

Copy link
Contributor

@linaori linaori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides of my comment about the convenient vs better, 👍 nice changes!

@javiereguiluz
Copy link
Member Author

I'm glad to tell you that I replaced "better" by "more convenient" 😄 Thank you all for the reviews!

@javiereguiluz javiereguiluz merged commit 2412bf2 into symfony:4.2 Jun 14, 2019
javiereguiluz added a commit that referenced this pull request Jun 14, 2019
…r (javiereguiluz)

This PR was squashed before being merged into the 4.2 branch (closes #11747).

Discussion
----------

Reworded the Setup article about the local Symfony server

On Symfony Slack, some people like @beryllium, @ro0NL and @dkarlovi mentioned that this intro article is not explicit enough about the requirement of installing the Symfony server before continuing. Let's improve it. Thanks.

Commits
-------

2412bf2 Reworded the Setup article about the local Symfony server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants